Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

FIX use default boto args (use_ssl) for get_client #335

Conversation

ConstantinoSchillebeeckx
Copy link

@ConstantinoSchillebeeckx ConstantinoSchillebeeckx commented Nov 6, 2023

A small fix to the method (introduced in #322) that gets the S3 boto client that sets use_ssl to True; the default client uses this setting and it would be best to maintain those default settings.

I ran into this because we, by default, reject all bucket traffic that isn't encrypted.

This is small enough and it was minimal effort for me to create this PR (instead of first creating an issue); lemme know if you want an issue first.

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@ConstantinoSchillebeeckx ConstantinoSchillebeeckx requested a review from a team as a code owner November 6, 2023 16:25
@desertaxle
Copy link
Member

Thanks for the PR! This was fixed in #328 and released in v0.4.2, so I'm going to close this PR.

@desertaxle desertaxle closed this Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants